Fix locking of non-partitioned transactional tables #9070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested manually but no idea how to write automated test for that. |
findepi
reviewed
Sep 1, 2021
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/HiveTransaction.java
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/fix_unpartitioned_lock
branch
from
9180c7c
to
2a54afd
Compare
|
AC @findepi |
findepi
approved these changes
Sep 3, 2021
Comment on lines
72
to
73
| if (partitioned) { | ||
| if (tableHandle.getPartitions().isPresent()) { |
There was a problem hiding this comment.
You can fuse the IFs seince else branches are the same.
(Then it's IMO natural to make the lockedTables,lockedPartitions variables effectively final)
losipiuk
force-pushed
the
lo/fix_unpartitioned_lock
branch
from
2a54afd
to
055d45d
Compare
|
AC @findepi |
Without the fix we were using partition locking API in HMS even for non-partitioned tables. It happened if during execution we successfully completed predicate pushdown flow. Then in HiveTableHandle we had non-empty partitions list. It contained a single element with synthetic HivePartition object using UNPARTITIONED_ID id. It is used to pass information about bucket filtering. With the fix we are detecting such case in getValidWriteIds and locking whole table instead.
losipiuk
force-pushed
the
lo/fix_unpartitioned_lock
branch
from
055d45d
to
26bd036
Compare
findepi
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix we were using partition locking API in HMS even for
non-partitioned tables. It happened if during execution we successfully
completed predicate pushdown flow. Then in HiveTableHandle we had
non-empty partitions list. It contained a single element with synthetic
HivePartition object using UNPARTITIONED_ID id. It is used to pass
information about bucket filtering.
With the fix we are detecting such case in getValidWriteIds and locking
whole table instead.