Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UUID type in PostgreSQL connector #1011

Merged
merged 1 commit into from Jun 18, 2019

Conversation

3 participants
@pgagnon
Copy link
Member

commented Jun 17, 2019

Closes #647

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2019

@pgagnon pgagnon changed the title Add Postgresql UUID support Add support for UUID type in PostgreSQL connector Jun 17, 2019

@pgagnon pgagnon force-pushed the pgagnon:postgres-uuid branch from 327027f to e2a9319 Jun 17, 2019

@electrum
Copy link
Member

left a comment

Overall looks good.

@pgagnon pgagnon force-pushed the pgagnon:postgres-uuid branch 2 times, most recently from 02f48a4 to 96458ce Jun 17, 2019

@electrum
Copy link
Member

left a comment

I found that the tests were failing because TestingPrestoClient doesn't have support for UUID. This should fix it:

else if (UUID.equals(type)) {
    return java.util.UUID.fromString((String) value);
}

Note that you can run the test method or test class by clicking the green arrow next to it in IntelliJ.

@pgagnon pgagnon force-pushed the pgagnon:postgres-uuid branch from 96458ce to 47efe63 Jun 17, 2019

@pgagnon

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

CI has passed. 🎉

@electrum electrum added this to the 316 milestone Jun 18, 2019

@electrum electrum merged commit b669b57 into prestosql:master Jun 18, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
@electrum

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Merged, thanks!

@pgagnon pgagnon referenced this pull request Jul 4, 2019

Closed

Release notes for 316 #1000

5 of 6 tasks complete

@pgagnon pgagnon deleted the pgagnon:postgres-uuid branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.