Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Refresh completion caches properly when catalog or schema is changed #1016

Closed
wants to merge 1 commit into from

Conversation

2 participants
@takezoe
Copy link
Member

commented Jun 17, 2019

Currently, presto-cli's table name completion caches aren't refreshed when catalog or schema is changed by USE statement. This pull request fixes it by calling the refresh function after new session is set to QueryRunner.

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2019

@takezoe takezoe force-pushed the takezoe:cli-refresh-caches branch from 914f731 to cb599c0 Jun 18, 2019

@takezoe takezoe force-pushed the takezoe:cli-refresh-caches branch from cb599c0 to a8e3410 Jun 20, 2019

@takezoe

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Could someone review this? Is there any blocker or concern about this fix?

@electrum electrum added this to the 316 milestone Jul 4, 2019

@electrum

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Merged, thanks!

@electrum electrum closed this Jul 4, 2019

@electrum

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Sorry, we missed this one. Merged as c6fb64e (minor edit to shorten the commit title so it's not truncated on GitHub)

@electrum electrum referenced this pull request Jul 4, 2019

Closed

Release notes for 316 #1000

5 of 6 tasks complete

@takezoe takezoe deleted the takezoe:cli-refresh-caches branch Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.