Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust getOffset output in Columnar classes for trimmed element blocks #1027

Merged
merged 1 commit into from Jun 24, 2019

Conversation

2 participants
@phd3
Copy link
Contributor

commented Jun 20, 2019

ColumnarArray constructor stores the underlying element block in ArrayBlock after a getRegion invocation. getOffset method in this class does not account for this, and instead returns indices pointing to original element block (without the trimming).

We need to access these offsets in #901 , and incorrect offset values cause failures in cases where offsets[offsetsOffset] is not zero. Another approach is to account for this in accessors of this class. But I think that making indices from getOffset consistent with getElementsBlock is a reasonable choice.

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2019

@findepi findepi requested a review from dain Jun 20, 2019

@dain

dain approved these changes Jun 24, 2019

@dain dain merged commit 09db394 into prestosql:master Jun 24, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
@dain

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.