Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connector to override min schedule split batch size #1251

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@kokosing
Copy link
Member

commented Aug 4, 2019

Allow connector to override min schedule split batch size

@cla-bot cla-bot bot added the cla-signed label Aug 4, 2019

@kokosing kokosing requested a review from dain Aug 4, 2019

@kokosing kokosing added the WIP label Aug 4, 2019

@@ -24,6 +24,8 @@
import io.prestosql.spi.connector.ConnectorSplitSource;

This comment has been minimized.

Copy link
@sopel39

sopel39 Aug 5, 2019

Member

Some rationale in commit message would be great.

Allow connector to override min schedule split batch size
Some connectors require more time to produce splits. Waiting for
global min schedule split batch size could lead to unnecessarily high
query duration.

@kokosing kokosing force-pushed the kokosing:origin/master/149_min_splits branch from 0029931 to 3ec2e50 Aug 5, 2019

@dain

dain approved these changes Aug 5, 2019

@kokosing kokosing removed the WIP label Aug 6, 2019

@kokosing kokosing merged commit 1e4f155 into prestosql:master Aug 6, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details

@kokosing kokosing deleted the kokosing:origin/master/149_min_splits branch Aug 6, 2019

@kokosing kokosing referenced this pull request Aug 6, 2019

Open

Release notes for 318 #1238

1 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.