Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow treating forwarded HTTPS requests over HTTP as secure #1442

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@bill-warshaw
Copy link
Member

commented Sep 4, 2019

  • If http-server.authentication.allow-forwarded-https is set to true,
    HTTP requests with the X-Forwarded-Proto header will be treated as secure and can be authenticated
  • Configuration defaults to false
  • Addresses #1246

@cla-bot cla-bot bot added the cla-signed label Sep 4, 2019

@bill-warshaw bill-warshaw force-pushed the bill-warshaw:enable_https_forwarding branch from b96ab71 to 9004a0b Sep 6, 2019

@dain dain self-assigned this Sep 9, 2019

Allow treating forwarded HTTPS requests over HTTP as secure
* If `http-server.authentication.allow-forwarded-https` is set to `true`,
  HTTP requests with the `X-Forwarded-Proto` header will be treated
  as secure and can be authenticated
* Configuration defaults to `false`

@bill-warshaw bill-warshaw force-pushed the bill-warshaw:enable_https_forwarding branch from 9004a0b to 27f80bd Sep 10, 2019

@dain
dain approved these changes Sep 11, 2019

@dain dain merged commit 49781dc into prestosql:master Sep 11, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details

@bill-warshaw bill-warshaw deleted the bill-warshaw:enable_https_forwarding branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.