Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix starvation while waiting for minimum number of workers #155
Conversation
cla-bot
bot
added
the
cla-signed
label
Feb 4, 2019
dain
force-pushed the
dain:fix-wait-for-minimum-workers-starvation
branch
from
efb67ab
to
14536d9
Feb 4, 2019
raghavsethi
reviewed
Feb 4, 2019
| @@ -124,6 +124,11 @@ public synchronized void verifyInitialMinimumWorkersRequirement() | |||
| minimumWorkerRequirementMet = true; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a listener that completes when the minimum number of workers for the cluster has been met. | |||
| * Note: caller should not use add a listener using the direct executor, as this can delay the | |||
This comment has been minimized.
This comment has been minimized.
raghavsethi
Feb 4, 2019
•
Contributor
Typo
Note: caller should not add a listener using the direct executor
raghavsethi
referenced this pull request
Feb 5, 2019
Merged
Fix starvation while waiting for minimum number of workers #12301
dain
force-pushed the
dain:fix-wait-for-minimum-workers-starvation
branch
from
14536d9
to
f7fe35c
Feb 5, 2019
dain
merged commit f7fe35c
into
prestosql:master
Feb 5, 2019
1 check passed
verification/cla-signed
Details
dain
deleted the
dain:fix-wait-for-minimum-workers-starvation
branch
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dain commentedFeb 4, 2019
Callers of waitForMinimumWorkers should not use a direct executor in listeners, as this can delay notifications to other listeners.