New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starvation while waiting for minimum number of workers #155

Merged
merged 1 commit into from Feb 5, 2019

Conversation

2 participants
@dain
Copy link
Member

dain commented Feb 4, 2019

Callers of waitForMinimumWorkers should not use a direct executor in listeners, as this can delay notifications to other listeners.

@cla-bot cla-bot bot added the cla-signed label Feb 4, 2019

@dain dain force-pushed the dain:fix-wait-for-minimum-workers-starvation branch from efb67ab to 14536d9 Feb 4, 2019

@@ -124,6 +124,11 @@ public synchronized void verifyInitialMinimumWorkersRequirement()
minimumWorkerRequirementMet = true;
}

/**
* Returns a listener that completes when the minimum number of workers for the cluster has been met.
* Note: caller should not use add a listener using the direct executor, as this can delay the

This comment has been minimized.

@raghavsethi

raghavsethi Feb 4, 2019

Contributor

Typo
Note: caller should not add a listener using the direct executor

@raghavsethi
Copy link
Contributor

raghavsethi left a comment

LGTM pending typo.

Fix starvation while waiting for minimum number of workers
Callers of waitForMinimumWorkers should not use a direct executor in listeners,
as this can delay notifications to other listeners.

@dain dain force-pushed the dain:fix-wait-for-minimum-workers-starvation branch from 14536d9 to f7fe35c Feb 5, 2019

@dain dain merged commit f7fe35c into prestosql:master Feb 5, 2019

1 check passed

verification/cla-signed
Details

@dain dain deleted the dain:fix-wait-for-minimum-workers-starvation branch Feb 5, 2019

@dain dain referenced this pull request Feb 5, 2019

Closed

Release notes for 302 #125

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment