Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various code cleanups #1661

Merged
merged 3 commits into from Oct 9, 2019

Conversation

@electrum
Copy link
Member

commented Oct 3, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2019
@dain

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

There are some style errors:

[INFO] There are 5 errors reported by Checkstyle 8.16 with checkstyle/airbase-checks.xml ruleset.
[ERROR] src/main/java/io/prestosql/plugin/hive/metastore/thrift/ThriftMetastoreUtil.java:[81,8] (imports) UnusedImports: Unused import - java.util.Locale.
[ERROR] src/test/java/io/prestosql/plugin/hive/TestHiveFileFormats.java:[22,8] (imports) UnusedImports: Unused import - io.airlift.slice.Slices.
[ERROR] src/test/java/io/prestosql/plugin/hive/AbstractTestHiveFileFormats.java:[42,8] (imports) UnusedImports: Unused import - io.prestosql.tests.StructuralTestUtil.
[ERROR] src/test/java/io/prestosql/plugin/hive/metastore/TestRecordingHiveMetastore.java:[29,8] (imports) UnusedImports: Unused import - io.prestosql.spi.security.PrincipalType.
[ERROR] src/test/java/io/prestosql/plugin/hive/metastore/thrift/TestThriftMetastoreConfig.java:[22,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
Copy link
Member

left a comment

LGTM

minor comments

squash Make field final in FixedPageSource commit with the rest of the cleanup

@electrum

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

I didn't squash the commit because FixedPageSource is in the SPI and the last commit is limited to the Hive connector.

@electrum electrum force-pushed the electrum:cleanup branch from ce81772 to b0e31c3 Oct 9, 2019
@electrum electrum merged commit adc9c78 into prestosql:master Oct 9, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.