New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 302 release notes #175

Closed
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@dain
Copy link
Member

dain commented Feb 6, 2019

Resolves #125

@cla-bot cla-bot bot added the cla-signed label Feb 6, 2019

@dain dain force-pushed the dain:release-302 branch 2 times, most recently from d20337b to 0bf8a0c Feb 6, 2019

* Fix Parquet predicate pushdown for ``smallint``, ``tinyint`` types. (:issue:`131`)
* Add support for Google Cloud Storage (GCS). Credentials can be provided globally using the
``hive.gcs.json-key-file-path`` configuration property, or as a client-provided extra credential
named ``hive.gcs`` if the ``hive.gcs.use-access-token`` is enabled. (:issue:`124`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

Change the first one from hive.gcs to hive.gcs.oauth (final name)

This comment has been minimized.

@electrum

electrum Feb 7, 2019

Member
named ``hive.gcs.oauth`` if the ``hive.gcs.use-access-token`` is enabled. (:issue:`124`)
* Add :doc:`/connector/elasticsearch`. (:issue:`118`)
* Add support for ``boolean`` type to :func:`approx_distinct`. (:issue:`82`)
* Add support for boolean columns to ``EXPLAIN`` with type ``IO``. (:issue:`157`)
* Add SphericalGeography type and related functions. (:issue:`166`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

How about

* Add ``SphericalGeography`` type and related :doc:`geospatial functions </functions/geospatial>`. (:issue:`166`)
* Add support for ``boolean`` type to :func:`approx_distinct`. (:issue:`82`)
* Add support for boolean columns to ``EXPLAIN`` with type ``IO``. (:issue:`157`)
* Add SphericalGeography type and related functions. (:issue:`166`)
* Remove deprecated system pool. (:issue:`168`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

"system memory pool"?

* Add SphericalGeography type and related functions. (:issue:`166`)
* Remove deprecated system pool. (:issue:`168`)
* Improve query performance for certain queries involving ``ROLLUP``. (:issue:`105`)
* Preserve table name quoting in the output of ``SHOW CREATE VIEW``. (:issue:`80`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

This seems like a bug and thus should be above with the fixes

-----------

* Add ``--trace-token`` option to set the trace token. (:issue:`117`)
* Add spilled data size debug output. (:issue:`161`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

How about

* Display spilled data size as part of debug information. (:issue:`161`)
* Add support for Google Cloud Storage (GCS). Credentials can be provided globally using the
``hive.gcs.json-key-file-path`` configuration property, or as a client-provided extra credential
named ``hive.gcs`` if the ``hive.gcs.use-access-token`` is enabled. (:issue:`124`)
* Fix support for tables with `external_location` property pointing to an empty S3 directory. (:issue:`75`)

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

Double backticks

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

Maybe change to

* Allow creating tables with the ``external_location`` property pointing to an empty S3 directory. (:issue:`75`)

This comment has been minimized.

@martint

martint Feb 6, 2019

Member

We weren't sure whether the fix was about creating tables that look like that or running queries over such tables.

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

It is for creating tables

If you try to create a table with this S3 prefix you will get an
"External location must be a directory" error.

I also read the code

This comment has been minimized.

@electrum

electrum Feb 6, 2019

Member

The problem is we verify the location when creating the table and that check was failing due to not being a directory that exists.

@dain dain force-pushed the dain:release-302 branch from 0bf8a0c to 0ee09ee Feb 7, 2019

* Fix Parquet predicate pushdown for ``smallint``, ``tinyint`` types. (:issue:`131`)
* Add support for Google Cloud Storage (GCS). Credentials can be provided globally using the
``hive.gcs.json-key-file-path`` configuration property, or as a client-provided extra credential
named ``hive.gcs.oauth`` if the ``hive.gcs.use-access-token`` is enabled. (:issue:`124`)

This comment has been minimized.

@electrum

electrum Feb 7, 2019

Member
  named ``hive.gcs.oauth`` if the ``hive.gcs.use-access-token`` configuration property is enabled. (:issue:`124`)
@electrum

This comment has been minimized.

Copy link
Member

electrum commented Feb 7, 2019

Merged, thanks!

@electrum electrum closed this Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment