Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing method in KuduInsertTableHandle #1986

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@martint
Copy link
Member

martint commented Nov 8, 2019

This went missing due to a bad rebase before I merged the original change.

@cla-bot cla-bot bot added the cla-signed label Nov 8, 2019
@ebyhr

This comment has been minimized.

Copy link
Contributor

ebyhr commented Nov 8, 2019

There is additional build failure.

[ERROR] /home/travis/build/prestosql/presto/presto-kudu/src/main/java/io/prestosql/plugin/kudu/KuduMetadata.java:[202,34] error: [MissingOverride] getTableMetadata implements method in ConnectorMetadata; expected @Override
    (see https://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override public ConnectorTableMetadata getTableMetadata(ConnectorSession session, ConnectorTableHandle tableHandle)'?

https://travis-ci.com/prestosql/presto/builds/135581475

@dain
dain approved these changes Nov 8, 2019
@martint

This comment has been minimized.

Copy link
Member Author

martint commented Nov 8, 2019

Hmm.. that's annoying. Is the only way to see the errors from errorprone to run the maven build (which doesn't even work out of the box due to thrift-api)? (@findepi?)

This went missing due to a bad rebase before the
original change got merged.
@martint martint force-pushed the martint:kudu branch from f692f85 to fe31af1 Nov 8, 2019
@findepi

This comment has been minimized.

Copy link
Member

findepi commented Nov 8, 2019

Is the only way to see the errors from errorprone to run the maven build

yes
when developing, intellij's inspections are even better
i wish we could run intellij's inspections directly on travis, but this would require committing .iml files, which i don't want to do

that's why we cannot enable errorprone's default, we can enable only selected features of it

@findepi findepi merged commit 13c5abf into prestosql:master Nov 8, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.