Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure loaded block has expected positions count #2258

Closed
wants to merge 1 commit into from

Conversation

@sopel39
Copy link
Member

sopel39 commented Dec 12, 2019

No description provided.

@sopel39 sopel39 requested a review from dain Dec 12, 2019
@cla-bot cla-bot bot added the cla-signed label Dec 12, 2019
@@ -376,6 +379,9 @@ private void load(boolean recursive)
}

block = requireNonNull(loader.load(), "loader returned null");
if (block.getPositionCount() != positionsCount) {
throw new IllegalStateException(format("Loaded block positions count (%s) doesn't match lazy block positions count (%s)", block.getPositionCount(), positionsCount));

This comment has been minimized.

Copy link
@dain

dain Dec 13, 2019

Member

Maybe say "block is invalid" or something about it being not loadable because there is another projection... if this ever appears it will be very confusing

This comment has been minimized.

Copy link
@sopel39

sopel39 Dec 14, 2019

Author Member

Maybe say "block is invalid" or something about it being not loadable because there is another projection

this only validates that loaded block is of same size as lazy block.

@sopel39

This comment has been minimized.

Copy link
Member Author

sopel39 commented Jan 8, 2020

Superseded by: #2431

@sopel39 sopel39 closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.