Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce exception stacks printed during tests #2443

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@dain
Copy link
Member

dain commented Jan 9, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 9, 2020
@@ -112,6 +112,7 @@
private static final OutputBufferId OUTPUT_BUFFER_ID = new OutputBufferId(0);
private static final CatalogName CONNECTOR_ID = new CatalogName("test");
private static final Duration ASSERT_WAIT_TIMEOUT = new Duration(1, HOURS);
public static final TaskId TASK_ID = new TaskId("query", 0, 0);

This comment has been minimized.

Copy link
@findepi

findepi Jan 9, 2020

Member

Does this reduce exception stacks printed during tests? or is it a separate change?

This comment has been minimized.

Copy link
@dain

dain Jan 9, 2020

Author Member

It does... The tests print some message when cleaning up about an invalid query ID.

@dain dain force-pushed the dain:test-output-cleanup branch from 7759e5b to a292a1d Jan 9, 2020
@dain dain merged commit 9f414da into prestosql:master Jan 10, 2020
34 checks passed
34 checks passed
maven-checks
Details
x (config-empty, suite-1)
Details
hive-tests (config-empty)
Details
x (config-empty, suite-2)
Details
hive-tests (config-hdp3)
Details
x (config-empty, suite-3)
Details
x (config-empty, suite-5)
Details
x (config-empty, suite-6-non-generic)
Details
x (config-empty, suite-7-non-generic)
Details
x (config-hdp3, suite-1)
Details
x (config-hdp3, suite-2)
Details
x (config-hdp3, suite-3)
Details
x (config-hdp3, suite-5)
Details
x (config-cdh5, suite-1)
Details
x (config-cdh5, suite-2)
Details
x (config-cdh5, suite-3)
Details
x (config-cdh5, suite-5)
Details
error-prone-checks
Details
kudu-tests
Details
web-ui-checks
Details
test-other-modules
Details
x (presto-main)
Details
x (presto-tests) x (presto-tests)
Details
x (presto-tests -P ci-only)
Details
x (presto-raptor-legacy)
Details
x (presto-accumulo)
Details
x (presto-cassandra)
Details
x (presto-hive,presto-orc)
Details
x (presto-hive,presto-parquet -P test-parquet)
Details
x (presto-mongodb,presto-kafka,presto-elasticsearch)
Details
x (presto-redis)
Details
x (presto-sqlserver,presto-postgresql,presto-mysql)
Details
x (presto-phoenix,presto-iceberg)
Details
verification/cla-signed
Details
@dain dain deleted the dain:test-output-cleanup branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.