Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary and invalid GuardedBy in ArbitraryOutputBuffer #2713

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@dain
Copy link
Member

dain commented Feb 3, 2020

No description provided.

GuardedBy annotation on ArbitraryOutputBuffer.checkFlushComplete is
not needed since method is thread safe, and invalid because callers
do not have a lock.
@dain dain requested a review from findepi Feb 3, 2020
@cla-bot cla-bot bot added the cla-signed label Feb 3, 2020
@sopel39
sopel39 approved these changes Feb 3, 2020
@dain dain merged commit 920e621 into prestosql:master Feb 3, 2020
34 checks passed
34 checks passed
maven-checks
Details
hive-tests (config-empty)
Details
x (config-empty, suite-1)
Details
hive-tests (config-hdp3)
Details
x (config-empty, suite-2)
Details
x (config-empty, suite-3)
Details
x (config-empty, suite-5)
Details
x (config-empty, suite-6-non-generic)
Details
x (config-empty, suite-7-non-generic)
Details
x (config-hdp3, suite-1)
Details
x (config-hdp3, suite-2)
Details
x (config-hdp3, suite-3)
Details
x (config-hdp3, suite-5)
Details
x (config-cdh5, suite-1)
Details
x (config-cdh5, suite-2)
Details
x (config-cdh5, suite-3)
Details
x (config-cdh5, suite-5)
Details
error-prone-checks
Details
kudu-tests
Details
web-ui-checks
Details
test-other-modules
Details
x (presto-main)
Details
x (presto-tests) x (presto-tests)
Details
x (presto-tests -P ci-only)
Details
x (presto-raptor-legacy)
Details
x (presto-accumulo)
Details
x (presto-cassandra)
Details
x (presto-hive,presto-orc)
Details
x (presto-hive,presto-parquet -P test-parquet)
Details
x (presto-mongodb,presto-kafka,presto-elasticsearch)
Details
x (presto-redis)
Details
x (presto-sqlserver,presto-postgresql,presto-mysql)
Details
x (presto-phoenix,presto-iceberg)
Details
verification/cla-signed
Details
@dain dain deleted the dain:fix-arbitrary-buffer-annotation branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.