Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping during URI creation in PrestoS3FileSystem #2756

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@dain
Copy link
Member

dain commented Feb 7, 2020

Forming a URI by concatination and then parsing breaks for escaped URIs.

Forming a URI by concatination and then parsing breaks for escaped URIs.
@cla-bot cla-bot bot added the cla-signed label Feb 7, 2020
@dain dain requested a review from electrum Feb 7, 2020
Copy link
Member

electrum left a comment

I think we have a utility at the bottom that does this.

@dain dain merged commit 2fdf52f into prestosql:master Feb 7, 2020
34 checks passed
34 checks passed
maven-checks
Details
hive-tests (config-empty)
Details
x (config-empty, suite-1)
Details
hive-tests (config-hdp3)
Details
x (config-empty, suite-2)
Details
x (config-empty, suite-3)
Details
x (config-empty, suite-5)
Details
x (config-empty, suite-6-non-generic)
Details
x (config-empty, suite-7-non-generic)
Details
x (config-hdp3, suite-1)
Details
x (config-hdp3, suite-2)
Details
x (config-hdp3, suite-3)
Details
x (config-hdp3, suite-5)
Details
x (config-cdh5, suite-1)
Details
x (config-cdh5, suite-2)
Details
x (config-cdh5, suite-3)
Details
x (config-cdh5, suite-5)
Details
error-prone-checks
Details
kudu-tests
Details
web-ui-checks
Details
test-other-modules
Details
x (presto-main)
Details
x (presto-tests) x (presto-tests)
Details
x (presto-tests -P ci-only)
Details
x (presto-raptor-legacy)
Details
x (presto-accumulo)
Details
x (presto-cassandra)
Details
x (presto-hive,presto-orc)
Details
x (presto-hive,presto-parquet -P test-parquet)
Details
x (presto-mongodb,presto-kafka,presto-elasticsearch)
Details
x (presto-redis)
Details
x (presto-sqlserver,presto-postgresql,presto-mysql)
Details
x (presto-phoenix,presto-iceberg)
Details
verification/cla-signed
Details
@dain dain deleted the dain:fix-s3-uri-construction branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.