Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify schema exists for USE statement #2764

Merged
merged 1 commit into from Feb 9, 2020
Merged

Conversation

@electrum
Copy link
Member

electrum commented Feb 7, 2020

Fixes #2763

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2020
@mosabua

This comment has been minimized.

Copy link
Member

mosabua commented Feb 8, 2020

Nice!

@electrum electrum force-pushed the electrum:useschema branch 2 times, most recently from 64da24f to a7a1c65 Feb 8, 2020
@dain
dain approved these changes Feb 8, 2020
@findepi

This comment has been minimized.

Copy link
Member

findepi commented Feb 8, 2020

@mosabua FYI i think you still can "enter" a schema that does not exist, via CLI --catalog, --schema

@findepi
findepi approved these changes Feb 8, 2020
Copy link
Member

findepi left a comment

Would be nice to have a test

@kokosing

This comment has been minimized.

Copy link
Member

kokosing commented Feb 8, 2020

i think you still can "enter" a schema that does not exist, via CLI --catalog, --schema

Same applies to jdbc properties I guess.

@electrum electrum force-pushed the electrum:useschema branch from a7a1c65 to a0b8791 Feb 8, 2020
@electrum electrum force-pushed the electrum:useschema branch from a0b8791 to 6c4c31d Feb 9, 2020
@electrum

This comment has been minimized.

Copy link
Member Author

electrum commented Feb 9, 2020

@findepi I added an engine test

@electrum electrum merged commit eeeaf76 into prestosql:master Feb 9, 2020
34 checks passed
34 checks passed
maven-checks
Details
hive-tests (config-empty)
Details
x (config-empty, suite-1)
Details
hive-tests (config-hdp3)
Details
x (config-empty, suite-2)
Details
x (config-empty, suite-3)
Details
x (config-empty, suite-5)
Details
x (config-empty, suite-6-non-generic)
Details
x (config-empty, suite-7-non-generic)
Details
x (config-hdp3, suite-1)
Details
x (config-hdp3, suite-2)
Details
x (config-hdp3, suite-3)
Details
x (config-hdp3, suite-5)
Details
x (config-cdh5, suite-1)
Details
x (config-cdh5, suite-2)
Details
x (config-cdh5, suite-3)
Details
x (config-cdh5, suite-5)
Details
error-prone-checks
Details
kudu-tests
Details
web-ui-checks
Details
test-other-modules
Details
x (presto-main)
Details
x (presto-tests) x (presto-tests)
Details
x (presto-tests -P ci-only)
Details
x (presto-raptor-legacy)
Details
x (presto-accumulo)
Details
x (presto-cassandra)
Details
x (presto-hive,presto-orc)
Details
x (presto-hive,presto-parquet -P test-parquet)
Details
x (presto-mongodb,presto-kafka,presto-elasticsearch)
Details
x (presto-redis)
Details
x (presto-sqlserver,presto-postgresql,presto-mysql)
Details
x (presto-phoenix,presto-iceberg)
Details
verification/cla-signed
Details
@electrum electrum deleted the electrum:useschema branch Feb 9, 2020
@electrum electrum mentioned this pull request Feb 15, 2020
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.