Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Slice methods to access byte array #3216

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

@electrum
Copy link
Member

electrum commented Mar 23, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 23, 2020
@pettyjamesm pettyjamesm self-requested a review Mar 23, 2020
Copy link
Member

pettyjamesm left a comment

Nice! Glad to see these finally getting some use, there are probably more than a couple places calling Slice#getBytes() which could go through these instead.

@dain
dain approved these changes Mar 23, 2020
@electrum electrum merged commit 21b3efe into prestosql:master Mar 25, 2020
37 checks passed
37 checks passed
maven-checks (1.8)
Details
hive-tests (config-empty)
Details
x (config-empty, suite-1)
Details
maven-checks (11)
Details
hive-tests (config-hdp3)
Details
x (config-empty, suite-2)
Details
maven-checks (13)
Details
x (config-empty, suite-3)
Details
x (config-empty, suite-5)
Details
x (config-empty, suite-6-non-generic)
Details
x (config-empty, suite-7-non-generic)
Details
x (config-empty, suite-8-non-generic)
Details
x (config-hdp3, suite-1)
Details
x (config-hdp3, suite-2)
Details
x (config-hdp3, suite-3)
Details
x (config-hdp3, suite-5)
Details
x (config-cdh5, suite-1)
Details
x (config-cdh5, suite-2)
Details
x (config-cdh5, suite-3)
Details
x (config-cdh5, suite-5)
Details
error-prone-checks
Details
test-other-modules
Details
web-ui-checks
Details
x (presto-main)
Details
x (presto-tests) x (presto-tests)
Details
x (presto-tests -P ci-only)
Details
x (presto-raptor-legacy)
Details
x (presto-accumulo)
Details
x (presto-cassandra)
Details
x (presto-hive,presto-orc)
Details
x (presto-hive,presto-parquet -P test-parquet)
Details
x (presto-mongodb,presto-kafka,presto-elasticsearch)
Details
x (presto-redis)
Details
x (presto-sqlserver,presto-postgresql,presto-mysql)
Details
x (presto-phoenix,presto-iceberg)
Details
x (presto-kudu)
Details
verification/cla-signed
Details
@electrum electrum deleted the electrum:bytearray branch Mar 25, 2020
@electrum

This comment has been minimized.

Copy link
Member Author

electrum commented Mar 25, 2020

@pettyjamesm Thanks for adding these methods. I'm sure there are more places, but I was only concerned with removing usages of sun.misc.Unsafe with this change (since it causes compiler warnings and is ugly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.