Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused columns in TableLayout APIs #362

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@martint
Copy link
Member

martint commented Mar 1, 2019

This feature is unused by existing connectors.

@cla-bot cla-bot bot added the cla-signed label Mar 1, 2019

@martint martint force-pushed the martint:columns branch from 9fe25ca to 1e05af6 Mar 2, 2019

@dain

dain approved these changes Mar 2, 2019

Copy link
Member

dain left a comment

You have failures in the style checks, but otherwise this looks good.

@martint martint force-pushed the martint:columns branch from 1e05af6 to 0cbd819 Mar 2, 2019

Remove unused columns in TableLayout APIs
This feature is unused by existing connectors.

@martint martint force-pushed the martint:columns branch from 0cbd819 to 3b8250c Mar 2, 2019

@martint

This comment has been minimized.

Copy link
Member Author

martint commented Mar 2, 2019

It turns out the Kudu connector is using them to prune the set of columns to produce. I have another change in mind to address that. I'll recreate this one once that's fixed.

@martint martint closed this Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.