Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single backquotes in documentation #378

Merged
merged 2 commits into from Mar 5, 2019

Conversation

3 participants
@electrum
Copy link
Member

electrum commented Mar 4, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2019

@electrum electrum requested a review from martint Mar 4, 2019

@dain

dain approved these changes Mar 4, 2019

@martint

This comment has been minimized.

Copy link
Member

martint commented Mar 4, 2019

Add some details to the commit message explaining the purpose of single backquotes in rst.

electrum added some commits Mar 4, 2019

Fail documentation build on single backquote
Single backquotes are used for the default role, which by default
does nothing (it gets rendered as italics). Any usages of it are
thus an error, and are almost certainly intended to be used for
code formatting, as that is how they are used in Markdown.

@electrum electrum force-pushed the electrum:sphinx branch from 42c3252 to ada6d8a Mar 5, 2019

@electrum electrum merged commit ada6d8a into prestosql:master Mar 5, 2019

1 check passed

verification/cla-signed
Details

@electrum electrum deleted the electrum:sphinx branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.