Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of metastore classes #426

Merged
merged 3 commits into from Mar 12, 2019

Conversation

2 participants
@electrum
Copy link
Member

electrum commented Mar 10, 2019

After the renames, this is what we have:

  • HiveMetastore -- High level metastore interface used by main Hive connector code. Has Presto metastore classes and operations like renameTable() and replaceTable().
  • ThriftMetastore -- Metastore interface that uses Thrift metastore classes and low level operations like alterTable(). It is expected to handle retries and throw PrestoException.
  • ThriftMetastoreClient -- Low level Thrift metastore client that throws TException.

I left the implementations ThriftHiveMetastore and ThriftHiveMetastoreClient alone because I didn't see any obvious good names and didn't want to break existing JMX stats.

@cla-bot cla-bot bot added the cla-signed label Mar 10, 2019

@dain

dain approved these changes Mar 10, 2019

@electrum electrum force-pushed the electrum:metastore branch 2 times, most recently from 28c3f3e to 0e3c69f Mar 11, 2019

@electrum electrum force-pushed the electrum:metastore branch from 0e3c69f to bf8a96b Mar 12, 2019

@electrum electrum merged commit 81be517 into prestosql:master Mar 12, 2019

1 check passed

verification/cla-signed
Details

@electrum electrum deleted the electrum:metastore branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.