Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for Search Guard in Elasticsearch connector #438
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to firstname.lastname@example.org. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.
electrum left a comment
This looks good.
A future enhancement is to split out the configs for the two different key types and bind the configs conditionally based on the configured type. Thus, it would be an error to provide configs for an un-configured type.