Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify block creation for all null values #445

Merged
merged 1 commit into from Mar 12, 2019

Conversation

3 participants
@Praveen2112
Copy link
Member

Praveen2112 commented Mar 11, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 11, 2019

@@ -37,6 +36,7 @@
import static io.prestosql.orc.metadata.Stream.StreamKind.DATA;
import static io.prestosql.orc.metadata.Stream.StreamKind.PRESENT;
import static io.prestosql.orc.stream.MissingInputStreamSource.missingStreamSource;
import static io.prestosql.spi.block.RunLengthEncodedBlock.create;

This comment has been minimized.

@martint

martint Mar 11, 2019

Member

I'd avoid a static import for this. "create" is a very generic word, so it makes the code harder to understand.

@Praveen2112 Praveen2112 force-pushed the Praveen2112:simplify_null_block_creation branch from 5dccc63 to 0b80e49 Mar 12, 2019

@Praveen2112

This comment has been minimized.

Copy link
Member Author

Praveen2112 commented Mar 12, 2019

@martint I have updated it.

@dain

dain approved these changes Mar 12, 2019

@dain dain merged commit 7f2b3cd into prestosql:master Mar 12, 2019

1 check passed

verification/cla-signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.