Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for query cancellation for JDBC and CLI #580

Merged
merged 1 commit into from Apr 3, 2019

Conversation

4 participants
@electrum
Copy link
Member

electrum commented Apr 3, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Apr 3, 2019

httpClient.newCall(request).execute().close();
}
catch (IOException ignored) {
// callers expect this method not to throw

This comment has been minimized.

Copy link
@kokosing

kokosing Apr 3, 2019

Member

please log it as debug

This comment has been minimized.

Copy link
@electrum

electrum Apr 3, 2019

Author Member

We don't have any logging in presto-client so I'm hesitant to add it just for this, as that could cause problems for the JDBC driver. The existing code does it async and ignores the result, so it isn't any worse. Also, if we cared about the response, we'd need to check that it was a successful HTTP request (it only throws if there is an I/O error, not due to HTTP 500 etc.)

This comment has been minimized.

Copy link
@findepi

findepi Apr 4, 2019

Member

Does this mean we may fail to cancel and ignore this?

Show resolved Hide resolved presto-client/src/main/java/io/prestosql/client/StatementClientV1.java Outdated

@electrum electrum force-pushed the electrum:client-abort branch from 1acdf68 to 77cddf4 Apr 3, 2019

@dain

dain approved these changes Apr 3, 2019

@electrum electrum merged commit 4eda310 into prestosql:master Apr 3, 2019

1 check passed

verification/cla-signed
Details

@electrum electrum deleted the electrum:client-abort branch Apr 3, 2019

@electrum electrum added this to the 307 milestone Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.