Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit TableScan when constraint is false #617

Merged
merged 1 commit into from Apr 11, 2019

Conversation

3 participants
@martint
Copy link
Member

martint commented Apr 11, 2019

No description provided.

@dain

dain approved these changes Apr 11, 2019

@martint martint merged commit 8cc5c1b into prestosql:master Apr 11, 2019

1 check passed

verification/cla-signed
Details
@findepi

This comment has been minimized.

Copy link
Member

findepi commented Apr 11, 2019

@electrum i think you uncovered this recently in #589. Would you be able to add a regression test for this one?

@martint

This comment has been minimized.

Copy link
Member Author

martint commented Apr 11, 2019

i think you uncovered this recently in #589. Would you be able to add a regression test for this one?

It's going to be hard to do that, since the regression is only in the shape of the plan, but it only happens for connectors that implement the new applyFilter API. I don't think we have a way to test plan shapes in the context of a connector.

@findepi

This comment has been minimized.

Copy link
Member

findepi commented Apr 11, 2019

the very basic would be to fire up an EXPLAIN and see that it does not contain table scan and it contains values instead.

also, you should be able to use getQueryRunner().createPlan(getSession(), "SELECT ...", WarningCollector.NOOP) in eg TestPostgreSqlIntegrationSmokeTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.