Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for static AWS credentials in GlueHiveMetastore #748

Merged
merged 1 commit into from May 12, 2019

Conversation

4 participants
@pgagnon
Copy link
Member

commented May 11, 2019

This PR adds support for specifying static AWS credentials for GlueHiveMetastore through two new configuration options, hive.metastore.glue.aws-access-key and hive.metastore.glue.aws-secret-key. This is helpful in situations where someone may want to access a glue catalog through Presto without running the cluster on AWS infrastructure.

I believe this may also resolve #726 as a side effect.

@cla-bot cla-bot bot added the cla-signed label May 11, 2019

@findepi
Copy link
Member

left a comment

LGTM, minor comments only.

@electrum do you want to have a look?

@pgagnon pgagnon force-pushed the pgagnon:glue-metastore-static-creds branch from 3fe5ce9 to b4c896b May 11, 2019

@pgagnon

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@findepi All review comments addressed.

@pgagnon pgagnon force-pushed the pgagnon:glue-metastore-static-creds branch from b4c896b to cb398d3 May 11, 2019

@pgagnon

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@electrum
Copy link
Member

left a comment

Looks good to me. I restarted the test

@electrum electrum merged commit 879b943 into prestosql:master May 12, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
verification/cla-signed
Details

@electrum electrum added this to the 311 milestone May 12, 2019

@pgagnon pgagnon deleted the pgagnon:glue-metastore-static-creds branch May 12, 2019

@@ -166,7 +168,12 @@ else if (config.getPinGlueClientToCurrentRegion()) {
}
}

if (config.getIamRole().isPresent()) {
if (config.getAwsAccessKey().isPresent() && config.getAwsSecretKey().isPresent()) {

This comment has been minimized.

Copy link
@sopel39

sopel39 May 13, 2019

Member

I wonder if io.prestosql.plugin.hive.s3.PrestoS3FileSystem#createAwsCredentialsProvider could be extracted and generalized to have common way of providing credentials to S3 and Glue

@electrum electrum referenced this pull request May 14, 2019

Closed

Release notes for 311 #716

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.