New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approx_distinct for boolean #82

Closed
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@ankitdixit
Copy link
Contributor

ankitdixit commented Jan 28, 2019

* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.facebook.presto.operator.aggregation;

This comment has been minimized.

@findepi

findepi Jan 28, 2019

Member

nit: you need to update the package (applies to new files).

This comment has been minimized.

@findepi

findepi Jan 28, 2019

Member

@electrum does Travis have a check for things like this?

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2019

@prestosql prestosql deleted a comment from cla-bot bot Jan 31, 2019

@prestosql prestosql deleted a comment from cla-bot bot Jan 31, 2019

@prestosql prestosql deleted a comment from martint Jan 31, 2019

@dain

This comment has been minimized.

Copy link
Member

dain commented Feb 4, 2019

@ankitdixit can you move the files from the com.facebook.presto package to the io.prestosql package?

@dain
Copy link
Member

dain left a comment

Can you move the files from the com.facebook.presto package to the io.prestosql package?

@martint

This comment has been minimized.

Copy link
Member

martint commented Feb 5, 2019

I updated the package names and merged it. Thanks!

@martint martint closed this Feb 5, 2019

@martint martint referenced this pull request Feb 5, 2019

Closed

Release notes for 302 #125

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment