Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan printer fixes #892

Merged
merged 2 commits into from Jun 4, 2019

Conversation

4 participants
@martint
Copy link
Member

commented Jun 3, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 3, 2019

@electrum

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Can we add a test for this?

@martint

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

The only way would be to match the exact output of explain, which would be super brittle.

@dain

dain approved these changes Jun 3, 2019

{
return node.getChildren().stream()
.map(plan::getNode)
.filter(Optional::isPresent)

This comment has been minimized.

Copy link
@findepi

findepi Jun 3, 2019

Member
Suggested change
.filter(Optional::isPresent)
.anyMatch(Optional::isPresent);

This comment has been minimized.

Copy link
@martint

martint Jun 3, 2019

Author Member

Ah, good catch. I just extracted a method from preexisting code. I'll fix it.

@martint martint force-pushed the martint:plan-printer branch from cc84924 to d61dbd9 Jun 3, 2019

@martint martint merged commit 2319f94 into prestosql:master Jun 4, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details

@martint martint added this to the 314 milestone Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.