Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prepared statement sql to query lifecycle events #908

Merged
merged 1 commit into from Jun 5, 2019

Conversation

3 participants
@sshardool
Copy link
Contributor

commented Jun 4, 2019

The commit makes two changes at a high level.
(1) Modifies QueryInfo and BasicQueryInfo for EXECUTE statements to include
sql query from the corresponding PREPARE.
(2) Update QueryMetadata to include the prepared sql for QueryCreated and
QueryCompleted events.

This partly fixes: prestodb/presto#12009

Add Prepared statement sql to query lifecycle events
The commit makes two changes at a high level.
(1) Modifies QueryInfo and BasicQueryInfo for EXECUTE statements to include
    sql query from the corresponding PREPARE.
(2) Update QueryMetadata to include the prepared sql for QueryCreated and
    QueryCompleted events.

This partly fixes:  prestodb/presto#12009
@cla-bot

This comment has been minimized.

Copy link

commented Jun 4, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shardool.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@dain dain self-requested a review Jun 4, 2019

@sshardool

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

This was approved on prestodb but never merged: prestodb/presto#12020
Applied the same patch to prestosql. @electrum

@martint

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jun 5, 2019

@cla-bot

This comment has been minimized.

Copy link

commented Jun 5, 2019

The cla-bot has been summoned, and re-checked this pull request!

@martint martint merged commit 11d3734 into prestosql:master Jun 5, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
@martint

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Merged. Thanks for your contribution!

@martint martint added this to the 314 milestone Jun 5, 2019

@martint martint referenced this pull request Jun 5, 2019

Closed

Release notes for 314 #879

2 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.