Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB ObjectId enhancements #933

Merged
merged 4 commits into from Jun 13, 2019

Conversation

@findepi
Copy link
Member

commented Jun 6, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2019
@findepi findepi force-pushed the findepi:findepi/object-id branch from cbb6484 to 4fddb56 Jun 6, 2019
@@ -65,8 +65,11 @@ public static Boolean equal(@SqlType("ObjectId") Slice left, @SqlType("ObjectId"

@ScalarOperator(IS_DISTINCT_FROM)
@SqlType(StandardTypes.BOOLEAN)
@SqlNullable
public static Boolean isDistinctFrom(@SqlType("ObjectId") Slice left, @IsNull boolean leftNull, @SqlType("ObjectId") Slice right, @IsNull boolean rightNull)
public static boolean isDistinctFrom(

This comment has been minimized.

Copy link
@martint

martint Jun 11, 2019

Member

The formatting change makes it hard to see that the real change here is the removal of @SqlNullable

This comment has been minimized.

Copy link
@martint

martint Jun 11, 2019

Member

Also, it's not clear how this "fixes IS DISTINCT for ...". Maybe add an explanation in the commit message describing how it was broken.

This comment has been minimized.

Copy link
@findepi

findepi Jun 11, 2019

Author Member

The formatting change makes it hard to see that the real change here is the removal of @SqlNullable

reverted

Also, it's not clear how this "fixes IS DISTINCT for ...". Maybe add an explanation in the commit message describing how it was broken.

added explanation

findepi added 4 commits Jun 6, 2019
`RowDistinctFromOperator` depends on `IS_DISTINCT_FROM` operators for
a row field, with `FAIL_ON_NULL` return convention (this is reasonable,
since `IS_DISTINCT_FROM` never returns null). Update `ObjectId`
`IS_DISTINCT_FROM` so that it also uses `FAIL_ON_NULL` return
convention.
@findepi findepi force-pushed the findepi:findepi/object-id branch from 4fddb56 to adeeb6c Jun 11, 2019
@findepi findepi merged commit a03a6f4 into prestosql:master Jun 13, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details
@findepi findepi deleted the findepi:findepi/object-id branch Jun 13, 2019
@findepi findepi referenced this pull request Jun 13, 2019
@electrum electrum added this to the 315 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.