Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purger to ExecutingStatementResource #944

Merged
merged 1 commit into from Jun 7, 2019

Conversation

3 participants
@dain
Copy link
Member

commented Jun 7, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 7, 2019

() -> {
try {
// snapshot the queries before checking states to avoid registration race
for (Entry<QueryId, Query> entry : ImmutableSet.copyOf(queries.entrySet())) {

This comment has been minimized.

Copy link
@martint

martint Jun 7, 2019

Member

There's no race here. You can just iterate over the query set directly.

@dain dain force-pushed the dain:fix-protocol-query-leak branch from c5d8be5 to 1d05ca1 Jun 7, 2019

@martint

martint approved these changes Jun 7, 2019

}
},
200,
200,

This comment has been minimized.

Copy link
@findepi

findepi Jun 7, 2019

Member

Does it have to be frequent?

This comment has been minimized.

Copy link
@dain

dain Jun 7, 2019

Author Member

This is a copy of the purger from QueuedStatementResource... this basically restores the old behavior

@dain dain force-pushed the dain:fix-protocol-query-leak branch from 1d05ca1 to 95663d3 Jun 7, 2019

@dain dain closed this Jun 7, 2019

@dain dain deleted the dain:fix-protocol-query-leak branch Jun 7, 2019

@dain dain merged commit 95663d3 into prestosql:master Jun 7, 2019

1 of 3 checks passed

Travis CI - Branch Build Created
Details
Travis CI - Pull Request Build Created
Details
verification/cla-signed
Details

@dain dain added this to the 314 milestone Jun 7, 2019

@dain dain referenced this pull request Jun 7, 2019

Closed

Release notes for 314 #879

2 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.