Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate type manager behind metadata interface #968

Merged
merged 3 commits into from Jun 16, 2019

Conversation

2 participants
@dain
Copy link
Member

commented Jun 12, 2019

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 12, 2019

@dain dain force-pushed the dain:encapsulate-type-manager branch 2 times, most recently from 798ec2f to 51415cc Jun 12, 2019

@dain dain requested a review from electrum Jun 13, 2019

import static io.prestosql.type.Re2JRegexpType.RE2J_REGEXP;
import static java.util.Objects.requireNonNull;

public final class TypeCoercion

This comment has been minimized.

Copy link
@electrum

electrum Jun 13, 2019

Member

I'm assuming all this code is simply moved

Show resolved Hide resolved ...ain/src/main/java/io/prestosql/connector/system/jdbc/TypesJdbcTable.java Outdated
Show resolved Hide resolved presto-main/src/main/java/io/prestosql/metadata/MetadataManager.java Outdated
Show resolved Hide resolved presto-main/src/main/java/io/prestosql/type/InternalTypeManager.java Outdated
Show resolved Hide resolved ...o-main/src/main/java/io/prestosql/sql/planner/LocalExecutionPlanner.java Outdated
Show resolved Hide resolved presto-hive/src/test/java/io/prestosql/plugin/hive/HiveTestUtils.java Outdated
Show resolved Hide resolved ...ain/src/main/java/io/prestosql/connector/system/jdbc/TypesJdbcTable.java Outdated
Show resolved Hide resolved presto-main/src/main/java/io/prestosql/metadata/MetadataManager.java
Show resolved Hide resolved presto-main/src/test/java/io/prestosql/metadata/TestFunctionRegistry.java Outdated
Show resolved Hide resolved ...umulo/src/test/java/io/prestosql/plugin/accumulo/TestAccumuloClient.java

@dain dain force-pushed the dain:encapsulate-type-manager branch from 51415cc to 2b681ac Jun 15, 2019

@dain dain merged commit cad323e into prestosql:master Jun 16, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details

@dain dain deleted the dain:encapsulate-type-manager branch Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.