Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adapter WorkProcessorOperator explicitly expose push page sink #995

Merged
merged 2 commits into from Jun 17, 2019

Conversation

2 participants
@sopel39
Copy link
Member

commented Jun 14, 2019

No description provided.

@sopel39 sopel39 requested a review from dain Jun 14, 2019

@cla-bot cla-bot bot added the cla-signed label Jun 14, 2019

@sopel39 sopel39 force-pushed the sopel39:ks/explicit_push_sink branch from 286ebaf to 7c89007 Jun 15, 2019

sopel39 added some commits Jun 14, 2019

Make adapter WorkProcessorOperator explicitly expose push page sink
Exposing push page sink gives more control to adapter
WorkProcessorOprator regarding page memory accouting and
how pages are initially processed. It's also more
straight forward.
@dain

dain approved these changes Jun 17, 2019

@sopel39

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

build error is unrelated

@sopel39 sopel39 merged commit 9bbbcdf into prestosql:master Jun 17, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
verification/cla-signed
Details

@sopel39 sopel39 deleted the sopel39:ks/explicit_push_sink branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.