Labeled framesets and related constants #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulcandth
requested changes
Aug 2, 2023
vulcandth
reviewed
Aug 2, 2023
Rangi42
reviewed
Aug 3, 2023
Rangi42
reviewed
Aug 3, 2023
Rangi42
reviewed
Aug 3, 2023
Rangi42
reviewed
Aug 3, 2023
|
Just gonna comment that I like the naming scheme :) |
Rangi42
approved these changes
Aug 14, 2023
Rangi42
changed the title
|
Once I work out the conflicts when merging this to pokegold; i'll merge this. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Labeled Framesets and Constants Related * Feedback Implemented with PascalCase and Constant Renames * Fix framset.asm comment spacing * `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA` * Feedback applied and labeled 1E & B2 * Fixed SpinningBone --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
vulcandth
added a commit
to pret/pokegold
that referenced
this pull request
Aug 22, 2023
* Labeled Framesets and Constants Related * Feedback Implemented with PascalCase and Constant Renames * Fix framset.asm comment spacing * `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA` * Feedback applied and labeled 1E & B2 * Fixed SpinningBone --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
github-actions bot
pushed a commit
to pret/pokegold
that referenced
this pull request
Aug 22, 2023
* Labeled Framesets and Constants Related * Feedback Implemented with PascalCase and Constant Renames * Fix framset.asm comment spacing * `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA` * Feedback applied and labeled 1E & B2 * Fixed SpinningBone --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
Idain
pushed a commit
to Idain/pokecrystal
that referenced
this pull request
Sep 11, 2023
* Labeled Framesets and Constants Related * Feedback Implemented with PascalCase and Constant Renames * Fix framset.asm comment spacing * `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA` * Feedback applied and labeled 1E & B2 * Fixed SpinningBone --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
Idain
pushed a commit
to Idain/pokecrystal
that referenced
this pull request
Sep 12, 2023
* Labeled Framesets and Constants Related * Feedback Implemented with PascalCase and Constant Renames * Fix framset.asm comment spacing * `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA` * Feedback applied and labeled 1E & B2 * Fixed SpinningBone --------- Co-authored-by: vulcandth <vulcandth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all Framesets with labels.