Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to enter tags #1049

Closed
mjang opened this issue Jan 31, 2021 · 5 comments
Closed

Unable to enter tags #1049

mjang opened this issue Jan 31, 2021 · 5 comments
Labels
type: bug Needs fix

Comments

@mjang
Copy link

mjang commented Jan 31, 2021

Current Behavior

Unable to set up tags in the following screen:

Screenshot from 2021-01-31 13-04-29

I can't type anything in the text boxes, or in the "Show tag publicly" checkbox. When I select "Save", I get an error message: "You are trying to change read-only data"

Expected Behavior

Successfully create a tag to link to various proposals

Steps to Reproduce

  1. Select Tags in the left-hand menu
  2. Click New Tag
  3. Try to type in whatever.

Context

Your Environment

Ubuntu 16.04

  • Chrome Version 88.0.4324.96 (Official Build) (64-bit)
  • Firefox 84.0.2
  • Version used:
  • Environment name and version (e.g. Chrome 39, python 3.5):
  • Operating System and version (desktop or mobile):
  • Link to your instance, if in production:
@rixx
Copy link
Member

rixx commented Jan 31, 2021

Creating tags is restricted to people who can either edit proposals, or who are reviewers while the active review phase permits the creation tags.

We should hide the link to the tag creation page in that case, though.

@rixx rixx closed this as completed in 3293a07 Jan 31, 2021
@mjang
Copy link
Author

mjang commented Jan 31, 2021

I am an active reviewer in this particular CfP.

It sounds like this is a legit bug. Why did you close it?

@rixx
Copy link
Member

rixx commented Jan 31, 2021

I closed the bug because I wrote a fix that hides the link to the tag creation page if the user does not have access rights, so nobody will come across the useless page you showed above. As this fixes the immediate problem, I consider the issue closed.

Can you confirm that in your event's review settings (pictured below) the permission is "add, remove and create" tags? In that case, I will re-open the issue, but otherwise, pretalx works as intended.
DeepinScreenshot_select-area_20210131232820

@plaindocs
Copy link

Looks like a bug to me. Although I wonder if it could be tangled up in the previous "can see other reviews" setting?

image

@rixx rixx reopened this Feb 1, 2021
@rixx rixx added the type: bug Needs fix label Feb 1, 2021
@plaindocs
Copy link

Just adding context, as full permissions admin I can add tags and tag talks

(Off topic, would be nice to see tags in list view)

@rixx rixx closed this as completed in ceb646b Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Needs fix
Projects
None yet
Development

No branches or pull requests

3 participants