Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link for downloading ical etc. from schedule does not appear #1140

Closed
ericsfraga opened this issue Jul 20, 2021 · 10 comments
Closed

The link for downloading ical etc. from schedule does not appear #1140

ericsfraga opened this issue Jul 20, 2021 · 10 comments
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help type: bug Needs fix

Comments

@ericsfraga
Copy link

Current Behavior

When visiting the schedule (for the JuliaCon 2021 conference specifically), there is meant to be a little drop-down menu from a button that looks like </>. This button does not appear for me. I am using Debian testing (up to date last week) and Firefox from that distribution. I do not block JavaScript and the only add-ons I have are https everywhere and facebook container.

Expected Behavior

I would expect to see the drop down menu button.

Steps to Reproduce

  1. Start firefox
  2. Visit https://pretalx.com/juliacon2021/schedule/
  3. Button next to "Version 0.2" is not there

Interestingly, if I use eww, the Emacs web browser, the links that would be in the drop down menu appear (although the button does not).

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, python 3.5): Firefox 78.11
  • Operating System and version (desktop or mobile): Debian 11.0
  • Link to your instance, if in production: https://pretalx.com/juliacon2021/schedule/
@rixx
Copy link
Member

rixx commented Jul 20, 2021

Thank you for this report. I can't tell why this would happen – the button is rendered unconditionally and I don't think that it uses some modern CSS to show up. That said, Firefox 78 is fairly old, so it could be due to that.

I can't currently reproduce the issue at all, I'm sorry to say. I'll be happy to merge a fix, of course, if somebody finds one!

@rixx rixx added good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help type: bug Needs fix labels Jul 20, 2021
@ericsfraga
Copy link
Author

Okay, no worries. Yes, I realise that v78 may be old but it's the stable release that Debian comes with. Thank you.

@giordano
Copy link

I don't know if this is related, but I don't see the </> link in Chrome 91 on Android, it isn't even when scrolling to the right (the schedule table is quite large)

Screenshot_20210721_162738

@rixx
Copy link
Member

rixx commented Jul 21, 2021

Yes, the exports aren't meant to be visible on mobile browsers, as the interface is already close to cluttered, and the export links aren't typically useful there.

@rixx
Copy link
Member

rixx commented Aug 4, 2021

Closing for now, happy to re-open if this pops up again.

@rixx rixx closed this as completed Aug 4, 2021
@confluence
Copy link

I have reproduced this in Firefox 92 and Chromium 94.0.4606.71. After some experimentation I realised that the dropdown disappears when the page is too narrow. By default I use a vertical tab bar on Firefox, which narrows the page just enough on my default monitor to trigger this. If I hide the tab bar or move the window to the wider monitor, the dropdown appears. I can confirm the same behaviour in response to width changes in Chromium.

This seems like a layout bug -- on desktop there's more than enough room to show this element.

@rixx
Copy link
Member

rixx commented Oct 8, 2021

As mentioned before:

Yes, the exports aren't meant to be visible on mobile browsers, as the interface is already close to cluttered, and the export links aren't typically useful there.

If we rework the general UI, we may change the location of the exports, but they are a niche use case already. Would of course happily merge a PR that improves the interface!

@confluence
Copy link

OK, I understand that, but this is happening in desktop browsers (as in the original report, but reproduced in new versions). There's a simple workaround (at least under the conditions that I have observed), so a fix is not urgent, but I'm commenting in the hopes that the issue will be reopened.

@rixx
Copy link
Member

rixx commented Oct 8, 2021

"mobile browsers" was meaning "smaller resolutions" – the display is cluttered at smaller sizes regardless of the device displaying it, after all. Sorry for being unclear about this.

@confluence
Copy link

I see, thank you -- I had earlier understood that to mean that completely different CSS is applied for mobile browsers. If it's the same responsive CSS used in both cases, I can see why this is happening.

My objection is that the minimum width boundary seems to be overly high (my vertical navigation is just wide enough to trigger the removal of the element; the rest of the window is more than wide enough to fit it comfortably), but I understand that you have to set it somewhere.

(The reason that this is a problem at all is that if the element is hidden there is no indication at all on the page that it's possible to export the schedule. I'm sure that you have some analytics about how often this feature is actually used; I wanted the .ics URL to add to Google Calendar. I couldn't find a way to do it, but after googling the software I knew that it should be possible -- which is how I eventually ended up here and figured out what my issue was.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help type: bug Needs fix
Projects
None yet
Development

No branches or pull requests

4 participants