Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speaker uploads #209

Closed
rixx opened this issue Nov 2, 2017 · 5 comments
Closed

Add speaker uploads #209

rixx opened this issue Nov 2, 2017 · 5 comments

Comments

@rixx
Copy link
Member

@rixx rixx commented Nov 2, 2017

Speakers may want to provide files for their submissions (their presentations, or extended reading material).

@rixx rixx added agenda labels Nov 2, 2017
@rixx rixx added this to the 2017-11 milestone Nov 2, 2017
@rixx rixx closed this in #229 Nov 5, 2017
@meisterluk
Copy link
Contributor

@meisterluk meisterluk commented Jan 25, 2019

I am wondering, is there any source code in place preventing SVGs to be uploaded? Because we are experiencing this issue here (speakers cannot upload SVG files, but PNG works).

Maybe related to submission.py

@rixx
Copy link
Member Author

@rixx rixx commented Feb 4, 2019

No, SVG files should be fine, except in image uploads.

@meisterluk
Copy link
Contributor

@meisterluk meisterluk commented Feb 4, 2019

Thanks, @rixx. Is there any particular reason? SVGs are images too?!

@rixx
Copy link
Member Author

@rixx rixx commented Feb 4, 2019

SVGs are not safe to allow as user uploads – sanitizing SVGs reliably is hard work, and there is no Python library that performs this task reliably, as far as I'm aware.

@meisterluk
Copy link
Contributor

@meisterluk meisterluk commented Feb 4, 2019

@rixx Fair enough, thanks for clarifying it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.