Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate placeholders in mail templates #215

Closed
rixx opened this issue Nov 3, 2017 · 1 comment
Closed

Validate placeholders in mail templates #215

rixx opened this issue Nov 3, 2017 · 1 comment
Labels
type: bug Needs fix

Comments

@rixx
Copy link
Member

rixx commented Nov 3, 2017

When mail templates include placeholders that are not in the context they are used with, a validation error should be raised, preventing saving the template. Otherwise, all mails from this template will fail rendering.
@rixx rixx added orga type: bug Needs fix labels Nov 3, 2017
rixx added a commit that referenced this issue Nov 3, 2017
@rixx
[tests] Add test for #215
bc7e490
rixx added a commit that referenced this issue Nov 3, 2017
@rixx
[tests] Add test for #215
c9cee75
@rixx
Copy link
Member Author

rixx commented Nov 4, 2017

Closed via c9cee75 and bc7e490.

@rixx rixx closed this as completed Nov 4, 2017
@Kunsi Kunsi mentioned this issue Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Needs fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rixx