Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails get linked to main domain, even if custom domain is set for a conference. #446

Closed
MacLemon opened this issue Jun 6, 2018 · 1 comment

Comments

@MacLemon
Copy link
Contributor

@MacLemon MacLemon commented Jun 6, 2018

Expected Behavior

When a custom domain is set for a conference, I'd expect links in Emails to be using that custom domain.

Current Behavior

Emails sent out are using the main domain instead of the custom one.

Steps to Reproduce

  1. Create a conference
  2. Add a custom domain in settings
  3. Send an Email (Invitation, etc.)
  4. Inspect the links in the email you received.

Context

Looks a little strange and some recipients may be confused by the different looks of the landing page. (Due to different branding or lack thereof.)

Your Environment

  • Version used: pretalx 0.6.1
  • Environment name and version (e.g. Chrome 39, python 3.5): Chrome 68, Firefox 60
  • Operating System and version (desktop or mobile): macOS 10.12.6
  • Link to your instance, if in production: https://conference.c3w.at/ (main domain of our pretalx instance) https://cfp.privacyweek.at/ (The custom domain we wanted emails to use for links)
@rixx
Copy link
Member

@rixx rixx commented Jun 16, 2018

I added a patch to a third-party library some time ago to make it possible for us to fix this, and then … I had a typo in the code that produced the custom url. Very clever.

@rixx rixx closed this in 17f30e9 Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.