New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event time in HTML export Tooltip and Details wrong but timeline correct. #500

Closed
oe1rfc opened this Issue Sep 11, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@oe1rfc

oe1rfc commented Sep 11, 2018

Expected Behavior

Event time in tooltip and events details view should display the correct event time.

Current Behavior

Overview tooltip shows several hours time difference (10:00 vs 17:00) to timeline in same page:
export overview

Event details also has wrong time:
export details

Event is scheduled in the editor at 17:00:
schedule editor

In the schedule.xml export the same event has a date value of "2018-10-22T10:00:00-05:00", which would be the correct time in a wrong time zone.

Steps to Reproduce

example instance at https://fahrplan.privacyweek.at/

Your Environment

  • Version used: 0.7.1
@oe1rfc

This comment has been minimized.

oe1rfc commented Sep 11, 2018

update: The same view is correct in the non-export schedule preview (//schedule/v/wip/).

@luto

This comment has been minimized.

Member

luto commented Sep 11, 2018

adding

from django.utils import timezone
timezone.activate(event.timezone)

to the export_schedule_html management command resolves this, but I am not sure, if that's the right way to tackle it.

@rixx any opinions?

I will apply the quick-fix manually for PW18, so there is no rush for this specific case.

@rixx

This comment has been minimized.

Member

rixx commented Sep 11, 2018

I think you'll want to use with django.utils.timezone.override(tz) to make sure you don't have unexpected side effects.

@rixx rixx closed this in 39c01f7 Sep 15, 2018

rixx added a commit that referenced this issue Sep 15, 2018

@rixx

This comment has been minimized.

Member

rixx commented Sep 15, 2018

Fix has been pushed – please re-open the issue if the fix is not sufficient.

@luto

This comment has been minimized.

Member

luto commented Sep 16, 2018

ah, thanks! :) I didn't get it to work yet, because the export still crashes under 3.8 :/ will investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment