Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed duration of a submission is not exported into new schedule #587

Closed
bentrm opened this Issue Feb 7, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@bentrm
Copy link

bentrm commented Feb 7, 2019

Expected Behavior

The default duration of the currently set submission type should be reflected in exports.

Changing the duration of a submission is possible by:

  • Setting a different duration for the submission.
  • Choosing different submission type which has a new default duration.

The currently set duration of a submission should be reflected in the backend planning view as well as in exports and the frontend. The WIP-view should show the currently set duration of the talk. Released schedules should show the duration that has been set at the time of the release of the schedule.

Current Behavior

After changing the submission type of a talk the duration of the new submission type is not reflected in exports and in the frontend.

After changing the duration of a talk already placed in the scheduling view, the new duration is reflected in the scheduling raster but not in exports.

Steps to Reproduce

  1. Create submission with distinct default duration setting no custom duration
  2. Accept submission
  3. Schedule submission
  4. Check talk duration in scheduling frontend
  5. Change submission to a new type with a different default duration setting no custom duration
  6. Check talk duration in backend (all fine here, new duration is shown), compare with frontend (old duration is shown)
  7. (Test in tandem with releasing the schedule for same output)

Context

We changed the acceptable duration of some talks. As the new duration is shown in the backend we did not notice this producing conflicts in the frontend exports.

Workaround

After changing the duration of a talk, remove it from the schedule pulling it into the unassigned talks row. Reschedule the talk pulling it into the previous spot of the time raster. Check and release schedule.

Your Environment

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Feb 7, 2019

No, this is correct – once the talks have been generated, you'll have to move/modify them and then release a new schedule version for these changes to take effect. Our rule is to not modify existing schedule releases, because those are presumed to be static. This includes exports.

I agree that the WIP schedule slots should be changed, but I definitely do not want to touch existing schedules in such an update.

@bentrm

This comment has been minimized.

Copy link
Author

bentrm commented Feb 7, 2019

The schedule has been released with a new version number. The talk is part of the released version and has been switched over to the new submission type beforehand. Comparing frontend and backend views of the same version of the schedule different talk durations are presented:

  • While in the backend looking at the released version of the schedule the new expected duration of the talk is shown.
  • The same version of the export/frontend schedule still has the old talk duration.

I do understand it may be necessary to change this particular talk by setting a custom duration. We were just confused by the different output in front and backend view.

@bentrm bentrm changed the title Default duration of submission type is not adapted in exports after changing submission type Changed duration of a submission is not exported into new schedule Feb 8, 2019

@bentrm

This comment has been minimized.

Copy link
Author

bentrm commented Feb 8, 2019

I rephrased the issue as I think this is not really an issue of the submission type but more broadly how and when the duration attribute of a submissions time slot is persisted. The workaround above seems to do the trick.

@rixx rixx closed this in fb60409 Feb 17, 2019

rixx added a commit that referenced this issue Feb 17, 2019

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Feb 17, 2019

I've introduced a patch that should fix both of the issues (changed submission type duration, and changed submission duration) by updating the WIP version of those talks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.