Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing time stamp offset in <day> elements in schedule.xml #618

Closed
johnjohndoe opened this Issue Mar 8, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@johnjohndoe
Copy link

johnjohndoe commented Mar 8, 2019

The FOSSGIS conference 2019 in Dresden uses a Pretalx instance.

Current Behavior

In the schedule.xml I noticed that the date format for a element changed:

<day date="2019-03-13" end="2019-03-14T03:59:00" index="1" start="2019-03-13T04:00:00">

Here the +01:00 is missing which is present in <date> elements, e.g. <date>2019-03-13T13:00:00+01:00</date>.

Expected Behavior

The format which was used at 35C3, e.g. ChaosWest and before and looks like this (modified example for above):

<day date="2019-03-13" end="2019-03-14T03:59:00+01:00" index="1" start="2019-03-13T04:00:00+01:00">

Context

This format change breaks the EventFahrplan parser.
For the moment I can patch the issue in the app for the FOSSGIS conference. A fix is not urgent. It would nice if you can make sure the format is consistent in future instances of Pretalx.

Your Environment

Related

johnjohndoe added a commit to johnjohndoe/CampFahrplan that referenced this issue Mar 8, 2019

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Mar 8, 2019

Apparently we broke day break localisation a while back, sorry about that!

As for validation: This is a bit of a difficult topic. pretalx supports the schedule.xml format for interoperability, but it's a bit of a fight, especially since we're just trying to keep up with implementation changes at frab as they happen. We've decided, for consistency and our peace of mind, to take the VOC interpretation of the schedule.xml as single source of truth. Hence we have tests running against their schedule.xml definition at https://github.com/voc/schedule/blob/master/validator/xsd/schedule.xml.xsd. So it would be best if you could add time zone validation to that file, so that we're all on the same page.

@rixx rixx closed this in 84b3e8b Mar 8, 2019

rixx added a commit that referenced this issue Mar 9, 2019

@johnjohndoe

This comment has been minimized.

Copy link
Author

johnjohndoe commented Mar 19, 2019

I met to @saerdnaer at the FOSSGIS conference. He told me that Pretalx used an outdated version of the XSD. @rixx, am I right, that therefore no further action is needed by me to prevent this issue in the future?

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Mar 19, 2019

That's correct – I completely forgot to update this issue. The Travis CI test runner now includes a test that checks if pretalx is on an up to date version of the schedule.xsd.

@saerdnaer

This comment has been minimized.

Copy link

saerdnaer commented Mar 19, 2019

@johnjohndoe

He told me that Pretalx used an outdated version of the XSD.

Actually @sophieschi was the one who told you that. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.