Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person unique ID missing in schedule export #641

Closed
Rufus125 opened this Issue Mar 28, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@Rufus125
Copy link

Rufus125 commented Mar 28, 2019

Current Behavior

URL to speaker is missing.

Expected Behavior

URL to speaker is included in schedule.xml

Steps to Reproduce

  1. open https://pretalx.linuxtage.at/glt19/schedule/export/schedule.xml
  2. Search for "<person " only ID and name is included in XML
  3. Speaker URL: https://pretalx.linuxtage.at/glt19/speaker/ED97ZT/
  4. Whole URL or ID (ED97ZT) is not found in schedule.xml

Context

I am trying to add the link to the speaker to the Android app: linuxtage/glt-companion#12

Your Environment

  • Version used: Made with love by pretalx v0.9.0.
  • Environment name and version (e.g. Chrome 39, python 3.5):
  • Operating System and version (desktop or mobile):
  • Link to your instance, if in production: https://pretalx.linuxtage.at/glt19

@Rufus125 Rufus125 changed the title Person unique ID missing in schedule Person unique ID missing in schedule export Mar 28, 2019

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Mar 28, 2019

We can't just add the speaker code to the schedule.xml export to retain frab compatibility and since that field expects a number, I can't just provide our code instead. I would probably merge a PR adding a URL that redirects from speaker ID to speaker code, if anybody wants to submit one!

@rixx

This comment has been minimized.

Copy link
Member

rixx commented Mar 29, 2019

Sidenote: The schedule.json does not undergo validation as rigid as the schedule.xml. Since I'm pretty sure that an additional field won't trip anybody up, I've added a "code" to speakers in the json export.

rixx added a commit that referenced this issue Mar 29, 2019

[schedule] Include a speaker's code in schedule.json
Since we use the code to look up people, that's a very good idea. We
can't do the same in the schedule.xml, but it's needed, as can be seen
in #641
@rixx

This comment has been minimized.

Copy link
Member

rixx commented Apr 4, 2019

/<event>/speaker/by-id/1234/ will now redirect if that ID is connected to a valid, viewable speaker of that event.

@rixx rixx closed this in f9219c8 Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.