Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Full submission content" new lines lost in HTML email format #645

Closed
glasnt opened this issue Apr 2, 2019 · 1 comment
Closed

"Full submission content" new lines lost in HTML email format #645

glasnt opened this issue Apr 2, 2019 · 1 comment

Comments

@glasnt
Copy link
Contributor

@glasnt glasnt commented Apr 2, 2019

Current Behavior

If a person submits a talk, they receive an email with the "Acknowledge Mail" template, but the generated "Full submission content" is poorly formatted.

Expected Behavior

The receipt of the submission should read well in both text and HTML emails.

Steps to Reproduce

  1. Submit a talk to any pretalx conference
  2. Check email for a reply.

Context

Organisers can format their reply to CFP submissions with the "Acknowledge Mail" template.

However, the formatted output is losing newlines. The code is correctly converting ** to <strong> (where?) but newlines are being lost.

Screen Shot 2019-04-02 at 9 11 36 pm

https://github.com/pretalx/pretalx/blob/master/src/pretalx/submission/models/submission.py#L535

Called in https://github.com/pretalx/pretalx/blob/master/src/pretalx/mail/models.py#L68

Your Environment

Hosted pretalx v0.9.0

@rixx
Copy link
Member

@rixx rixx commented Apr 2, 2019

Thank you for the fix (and yay for your first pretalx PR)!

@rixx rixx closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants