Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sneak Preview and Schedule are mutually exclusive #743

Closed
MacLemon opened this issue Jul 3, 2019 · 1 comment
Closed

Sneak Preview and Schedule are mutually exclusive #743

MacLemon opened this issue Jul 3, 2019 · 1 comment

Comments

@MacLemon
Copy link
Contributor

@MacLemon MacLemon commented Jul 3, 2019

Problem you are facing

When a schedule <slug>/schedule/ is activated, it's not possible to display the sneak preview <slug>/sneak/ anymore.
When no schedule <slug>/schedule/ is published, it's possible to view the sneak preview <slug>/sneak/.

Since we're using different URLs which match different cases, either one always delivers error pages which is inelegant.

Possible Solution

While no schedule is published, a call to <slug>/schedule/, given any sneak preview data is available, could deliver <slug>/sneak/ instead of an error page. This would be much more charming regarding visitors.

On the other hand, when a person visits <slug>/sneak/, but a sneak won't be delivered, because a schedule has already been published, a redirect to <slug>/schedule/ seems more appropriate.

Context

We're using cfp.privacyweek.at during the call for participation but, while the CfP is still active, we also publish a website fahrplan.privacyweek.at which is communicated to participants for finding the schedule.

Depending on orga progress currently either one will deliver an error.
This could be handled more friendly as described.

@rixx
Copy link
Member

@rixx rixx commented Jul 3, 2019

While no schedule is published, a call to <slug>/schedule/, given any sneak preview data is available, could deliver <slug>/sneak/ instead of an error page. This would be much more charming regarding visitors.

Agreed, this sounds like nice behaviour.

On the other hand, when a person visits <slug>/sneak/, but a sneak won't be delivered, because a schedule has already been published, a redirect to <slug>/schedule/ seems more appropriate.

This should already happen – we even have tests to show it does. Do you see different behaviour?

@rixx rixx closed this in 55bf196 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants