Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: reviews endpoint contains duplicates #754

Closed
alanderex opened this issue Jul 27, 2019 · 1 comment
Closed

API: reviews endpoint contains duplicates #754

alanderex opened this issue Jul 27, 2019 · 1 comment

Comments

@alanderex
Copy link

@alanderex alanderex commented Jul 27, 2019

Current Behavior

GET /api/events/{event}/reviews returns some reviews more than once.

Expected Behavior

Each review should be only returned once.

Steps to Reproduce

  1. GET /api/events/{event}/reviews
  2. continue with url from 'next' of result of 1. until 'next' is ''

The following calls all returned the review id 9519
https://pretalx.com/api/events/pyconde-pydata-berlin-2019/reviews/?limit=25&offset=125
https://pretalx.com/api/events/pyconde-pydata-berlin-2019/reviews/?limit=25&offset=375
https://pretalx.com/api/events/pyconde-pydata-berlin-2019/reviews/?limit=25&offset=1300

Context

We have to deduplicate the reviews, the issue is not obvious.
We only found this bug coincidentally.
Not too many reviews were affected.

Your Environment

Requests via API calls with requests, shouldn't matter here anyway.

@rixx
Copy link
Member

@rixx rixx commented Jul 28, 2019

Thank you for reporting this issue! I pushed a fix, which is also rolled out on pretalx.com. It will be included in the next bugfix release (1.0.4), and the next minor release (1.1.0).

Loading

rixx added a commit that referenced this issue Oct 15, 2019
The return count was correct, but elements appeared multiple times or
not at all due to an unordered queryset. Closes #754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants