Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biography field always empty in /api/events/<conf>/talks/ #773

Closed
Rafiot opened this issue Sep 12, 2019 · 8 comments

Comments

@Rafiot
Copy link
Contributor

commented Sep 12, 2019

Current Behavior

The biography field is never populated when querying /api/events/<conf>/talks/

Expected Behavior

biography populated with the data given by the speaker

Steps to Reproduce

  1. GET (authenticated) on https://<domain>/api/events/<conf>/talks/?limit=100
  2. Look at content

Your Environment

  • Version used: v1.0.3
@rixx rixx added the issue:bug 🐛 label Sep 12, 2019
@rixx

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Absolutely a bug, thank you for reporting. If you currently cannot update, please be advised that the /speakers endpoint does contain the biography as specified.

@rixx rixx closed this in bb5d5c9 Sep 12, 2019
rixx added a commit that referenced this issue Sep 12, 2019
It was present in the /speakers API endpoint at least. So if you cannot
currently upgrade and need the data, the speakers endpoint should help.

Closes #773
@rixx

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@Rafiot Not sure if this single bug warrants a bugfix release yet. Do you need one to get it working in production for yourself?

I pushed the fix also on the v1.0 branch, which is used to build bugfix releases on minor release lines, if you want to build off that.

@Rafiot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

No worries, I'm writing a small python module to query the API that will take care of it without touching the instance.

It won't be complete, but I'll publish it later today.

@Rafiot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@rixx

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Oh, nice! I had planned to write an API client sooner or later, but never got round to it.

@rixx

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Feel free to let me know (either on here or via mail) if there are any features you are missing in the API. (And consider that it might not be a read-only API forever … ;) )

@Rafiot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

If there is anything (maybe not this year, but who knows), I'll let you know per mail.

If you want to (co)maintain an official API client for pretalx, I'm happy to move the repository from circl to the pretalx organisation.

@rixx

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Let me look at it when I get a chance (I'm at a conference right now and a bit swamped). Thank you for the offer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.