Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select language for exports by URL #947

Closed
v0tti opened this issue Jun 8, 2020 · 2 comments
Closed

Select language for exports by URL #947

v0tti opened this issue Jun 8, 2020 · 2 comments
Labels
help wanted issue:feature size:small 🐁 stage:up for grabs 📤

Comments

@v0tti
Copy link

@v0tti v0tti commented Jun 8, 2020

Problem you are facing

The language of schedule exports (iCal and frab compatible) formats only seems to be configurable by the request header.
This leads to unexpected behavior when using the export URL in Scripts and other software that depends on consistent results.

Possible Solution

Make the language selectable via the path (e.g. .../schedule/de/export/schedule.xml for the German version).

Context

This seems to be similar to #279.
I experienced this problem while configuring the c3voc streaming website. It assigns streams to schedule rooms. In my case the room names were different for German and English. My local version was English and that's how i configured the room filters, but the script on the server downloaded the German version.

@rixx
Copy link
Member

@rixx rixx commented Jun 8, 2020

Thank you for bringing this up!

I'm hesitant to change the URL to the schedule exports – we would have to either maintain multiple paths, or maintain reliable redirects, which is made all the harder because exporters can be provided by plugins.

At the same time, it would be fairly easy to accept a ?lang=de queryparameter. Would that work for you, or am I overlooking limitations of adding language specification this way?

@rixx rixx added help wanted issue:feature size:small 🐁 stage:up for grabs 📤 labels Jun 8, 2020
@v0tti
Copy link
Author

@v0tti v0tti commented Jun 8, 2020

At the same time, it would be fairly easy to accept a ?lang=de queryparameter. Would that work for you, or am I overlooking limitations of adding language specification this way?

I do not see any reason why this would not work.

@rixx rixx closed this as completed in 76d57ca Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issue:feature size:small 🐁 stage:up for grabs 📤
Projects
None yet
Development

No branches or pull requests

2 participants