Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal questions #233

Merged
merged 4 commits into from Nov 10, 2017
Merged

Personal questions #233

merged 4 commits into from Nov 10, 2017

Conversation

@rixx
Copy link
Member

@rixx rixx commented Nov 7, 2017

This PR improves privacy concerns on user deletion/deactivation by deleting all answers giving to questions deemed 'personal'.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change is listed in the CHANGELOG.rst if appropriate.
@codecov
Copy link

@codecov codecov bot commented Nov 7, 2017

Codecov Report

Merging #233 into master will increase coverage by 0.09%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   87.35%   87.45%   +0.09%     
==========================================
  Files          74       74              
  Lines        3789     3794       +5     
  Branches      414      415       +1     
==========================================
+ Hits         3310     3318       +8     
+ Misses        346      342       -4     
- Partials      133      134       +1
Impacted Files Coverage Δ
src/pretalx/orga/forms/cfp.py 100% <ø> (ø) ⬆️
src/pretalx/submission/models/question.py 97.46% <100%> (+0.03%) ⬆️
src/pretalx/person/models/user.py 91.08% <50%> (+3.46%) ⬆️
@rixx rixx requested a review from luto Nov 7, 2017
@rixx rixx force-pushed the personal-questions branch from 273a983 to 75679fc Nov 10, 2017
@rixx rixx force-pushed the personal-questions branch from e6f8334 to 8632cd7 Nov 10, 2017
@luto
luto approved these changes Nov 10, 2017
@rixx rixx force-pushed the personal-questions branch from 8632cd7 to d989d60 Nov 10, 2017
@rixx rixx merged commit d989d60 into master Nov 10, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@rixx rixx deleted the personal-questions branch Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants