New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ical file for all talks of a speaker #304

merged 3 commits into from Jan 7, 2018


None yet
2 participants

luto commented Jan 1, 2018

Refs #67

How Has This Been Tested?

Using the automated tests provided, as well as clicking the new button in the speaker profile manually and importing the resulting file in my calendar.

Screenshots (if appropriate):



  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change is listed in the CHANGELOG.rst if appropriate.

@rixx rixx referenced this pull request Jan 3, 2018


Add ical export #67

5 of 8 tasks complete
@@ -30,6 +30,7 @@ class SpeakerProfile(LogMixin, models.Model):
class urls(EventUrls):
public = '{self.event.urls.base}/speaker/{self.user.code}'
talks_ical = '{self.urls.public}/talks.ical'

This comment has been minimized.


rixx Jan 7, 2018


I suppose it would make more sense to put the speaker code or speaker name here, in addition. Otherwise you'll end up with talks.ical, talks (2).ical, etc.

Also, we use .ics in other places, if memory serves, so I'd prefer this for consistency's sake.

This comment has been minimized.


luto Jan 7, 2018


The downloaded filename contains both the slug and a (cleaned) speaker name:

This comment has been minimized.


luto Jan 7, 2018


ical => ics fixed. :)


Apart from my one comment, this looks good to me, thank you!


rixx approved these changes Jan 7, 2018

@rixx rixx merged commit 53a2e9a into master Jan 7, 2018

4 checks passed

codecov/patch No report found to compare against
codecov/project No report found to compare against
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@rixx rixx deleted the 67-speaker-talks-ical branch Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment