Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by track #609

Closed
wants to merge 3 commits into from
Closed

Filter by track #609

wants to merge 3 commits into from

Conversation

@Nakaner
Copy link
Contributor

@Nakaner Nakaner commented Mar 3, 2019

This pull request enables organisers to filter submissions by track – both in the submission and the review list view. It is a good idea to merge #608 or apply a similar fix to because this pull request increases the width of the form.

I know that review teams can be configured to only see their tracks but why not add another filter in the frontend?

How Has This Been Tested?

Python 3.7, Firefox 65

Screenshots (if appropriate):

filter-by-open

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change is listed in the CHANGELOG.rst if appropriate.
@codecov
Copy link

@codecov codecov bot commented Mar 3, 2019

Codecov Report

Merging #609 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         137      137              
  Lines        7817     7821       +4     
  Branches      953      955       +2     
==========================================
+ Hits         6925     6928       +3     
  Misses        639      639              
- Partials      253      254       +1
Impacted Files Coverage Δ
src/pretalx/orga/views/submission.py 76.67% <100%> (ø) ⬆️
src/pretalx/orga/views/review.py 79.66% <100%> (ø) ⬆️
src/pretalx/submission/forms/submission.py 78.82% <75%> (-0.19%) ⬇️

@rixx
Copy link
Member

@rixx rixx commented Mar 29, 2019

Merged via manual rebase. Thank you for your contribution!

@rixx rixx closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants