Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[ready for review] Pre-fill SubmissionInfo form of CfP with track and submission_type #628
If the URL query string for the submission info form or the CfP landing page contains a track or submission_types field, they will be used to pre-fill the submission info form. If the values do not match any in the database, the fields will have their default as initial value.
Add slug fields to the SubmissionType and Track model in order to have a easy to query but still memorizeable (by humans) identifier because the i18n char fields are not designed to be queried.
Slugs for submission types and tracks can be choosen by organisers. The migration tries to set readable but unique values for existing entries in the database.
This allows to have two different CfP for different tracks of a conference outside of Pretalx and to point submitters to the "right" submission form for their track. In my case, a conference has about five "normal" and one academic track. The academic programme committee fears that their submitters don't select the right track due to the high number of thematic tracks for the normal part of the conference. (Sie sehen den Wald vor lauter Bäumen nicht) The behaviour of this feature is a bit like a anchor in an URL pointing to the right section of a longer web page.
I would like to have feedback on the implemention.
This feature is a feature known by experts at the moment due to a lack of a proper user documentation. Where shall I document it?
Mar 9, 2019
If I knew how to convert this pull request now to a normal pull request, I would do it. Unfortunately, the user interface lacks the button "mark ready for review" next to "This pull request is still a work in progress."
@rixx Shall I recreate this PR or can you review it and merge it manually?
changed the title
Pre-fill SubmissionInfo form of CfP with track and submission_type
Mar 9, 2019
I thought about serial vs. string for the slug field.
Pro integer/serial field:
I am happy to change that if you ask me to do so.
rixx left a comment
Having thought about it, I'm against adding a slug field, but for using a slug: Let's do it in a mixed format,
So I'd request that in the tables listing all submission types / tracks, that you'd add a link button "Copy prefilled CfP URL", which shows organisers that they can link to this submission type / track directly. You can just use Django's
@@ Coverage Diff @@ ## master #628 +/- ## ========================================== - Coverage 89.59% 89.59% -0.01% ========================================== Files 137 137 Lines 8100 8127 +27 Branches 998 1004 +6 ========================================== + Hits 7257 7281 +24 - Misses 569 572 +3 Partials 274 274